Skip to content
Snippets Groups Projects
  1. Aug 27, 2014
    • NeoRaider's avatar
      Merge pull request #68 from FreifunkBremen/gluon-cron-fix · 9d11f4bd
      NeoRaider authored
      gluon-cron: Fix endless loop parsing invalid lines
      9d11f4bd
    • Jan-Philipp Litza's avatar
      gluon-cron: Fix endless loop parsing invalid lines · afce06c3
      Jan-Philipp Litza authored
      Using the line
      ```
      * * * * echo "foobar"
      ```
      (notice the missing fifth time field) in a crontab causes gluon-cron
      to enter an endless loop while parsing it, thus it won't even execute
      the other, valid crontabs.
      
      This is caused by the loop in [line 138] where `begin - min`
      substracts the unsigned `min` from the signed `begin`. If now `begin`
      is invalid, `strict_atoi` returns -1 and the loop starts at
      `(-1)-1=MAX_INT` and runs while `i <= MAX_INT` which is always true.
      
      The real culprit lies in [line 134] where exactly this case
      `begin < min` is checked - but because of the signedness, this check doesn't
      work as expected either.
      
      The easiest solution is to make `min` a signed integer instead of an unsigned
      one, as we do not require it to be very large and only pass the constants 0 or
      1 to it.
      
      To avoid other similar problems, this patch makes the input variable `n` a
      signed integer as well.
      afce06c3
  2. Aug 25, 2014
  3. Aug 22, 2014
  4. Aug 18, 2014
  5. Aug 17, 2014
  6. Aug 16, 2014
  7. Aug 15, 2014
  8. Aug 10, 2014
  9. Aug 09, 2014
  10. Aug 08, 2014
  11. Aug 07, 2014
  12. Aug 06, 2014
  13. Aug 05, 2014
    • Nils Schneider's avatar
      Merge pull request #40 from digineo/private-wifi · 257787a0
      Nils Schneider authored
      gluon-luci-private-wifi: UI for enabling a private WLAN
      257787a0
    • Nils Schneider's avatar
      gluon-config-mode: modularize wizard · 3aecc920
      Nils Schneider authored
      This commit splits gluon-config-mode into several, mostly independent
      packages.
      
      * gluon-config-mode-core: basic functionality (required)
      * gluon-config-mode-hostname: hostname field
      * gluon-config-mode-autoupdater: show when autoupdater is enabled
      * gluon-config-mode-mesh-vpn: fastd vpn configuration, bw limit
      * gluon-config-mode-geo-location: geo coordinates
      * gluon-config-mode-contact-info: contact info field
      
      The package gluon-config-mode has been removed. You need to replace
      it with these packages (or any subset of them) in site.mk:
      
      * gluon-config-mode-hostname
      * gluon-config-mode-autoupdater
      * gluon-config-mode-mesh-vpn
      * gluon-config-mode-geo-location
      * gluon-config-mode-contact-info
      
      Note: It is not possible to deactivate the autoupdater in config mode
      anymore (expert mode will still allow it). Instead, a message is shown
      in case the autoupdater is enabled.
      3aecc920
  14. Aug 04, 2014
Loading