From 87ba9ecd85247110d33207d27eecf0c1b55a1145 Mon Sep 17 00:00:00 2001
From: Felix Baumann <felix.bau@gmx.de>
Date: Tue, 12 Dec 2023 22:01:00 +0100
Subject: [PATCH] targets.mk: fix inconsistent env variable BROKEN (#2934)

BROKEN TARGETS were built when BROKEN was set as a variable regardless of
it's value. Even an empty BROKEN variable caused BROKEN TARGETS to be
built. For DEVICES the number was evaluated and compared to true by Lua.

Make behavior consistent for relevant values UNSET/EMPTY/0 and 1:
UNSET/EMPTY/0: Don't build BROKEN TARGETS and DEVICES
1: Build BROKEN TARGETS and DEVICES

The behavior remains inconsistent for all positive numbers except 1.
(even floating point)
---
 targets/targets.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/targets/targets.mk b/targets/targets.mk
index 3a885f22..091d4a18 100644
--- a/targets/targets.mk
+++ b/targets/targets.mk
@@ -24,7 +24,7 @@ $(eval $(call GluonTarget,x86,legacy))
 $(eval $(call GluonTarget,x86,64))
 
 
-ifneq ($(BROKEN),)
+ifeq ($(BROKEN),1)
 $(eval $(call GluonTarget,bcm27xx,bcm2710)) # BROKEN: Untested
 $(eval $(call GluonTarget,mvebu,cortexa9)) # BROKEN: No 11s support
 endif
-- 
GitLab