From ec72d30b8f45210ae2bcb6efeda0b2328b232ad5 Mon Sep 17 00:00:00 2001 From: Sven Eckelmann <sven@narfation.org> Date: Mon, 25 Feb 2019 22:43:23 +0100 Subject: [PATCH] gluon-mesh-batman-adv: List neighbors with non-best direct link Links between two direct neighbors are not always the best route between these devices. The flag BATADV_ATTR_FLAG_BEST would not be set for these originator entries and the respondd module would just ignore this entry. This causes missing links in meshviewer and similar tools. And when the link quality is nearly equal and but fluctuates slightly, these links will from time to time appear and disappear on the map. Fixes: 2e0e24a9926d ("announce neighbours using alfred/gluon-announce") --- package/gluon-mesh-batman-adv/src/respondd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/package/gluon-mesh-batman-adv/src/respondd.c b/package/gluon-mesh-batman-adv/src/respondd.c index 43d512234..9896c28bd 100644 --- a/package/gluon-mesh-batman-adv/src/respondd.c +++ b/package/gluon-mesh-batman-adv/src/respondd.c @@ -666,9 +666,6 @@ static int parse_orig_list_netlink_cb(struct nl_msg *msg, void *arg) BATADV_ARRAY_SIZE(parse_orig_list_mandatory))) return NL_OK; - if (!attrs[BATADV_ATTR_FLAG_BEST]) - return NL_OK; - orig = nla_data(attrs[BATADV_ATTR_ORIG_ADDRESS]); dest = nla_data(attrs[BATADV_ATTR_NEIGH_ADDRESS]); tq = nla_get_u8(attrs[BATADV_ATTR_TQ]); -- GitLab